From b59b42d381dba03be61e73d2070c75ee15d174b7 Mon Sep 17 00:00:00 2001 From: Loretta Date: Sun, 26 Apr 2026 14:11:03 +0200 Subject: [PATCH] [LOADED_DOCS: 3 files, no new loads] Add Rule #6, remove host folder, update deployment docs - Introduced Rule #6 to all primary copilot-instructions.md files, enforcing authority checks, conservative rule application, and skill invocation over ad-hoc solutions. - Removed the obsolete Mango/FruitBank/ deployment-host folder and its copilot-instructions.md; updated REPOS.md to reflect the new repo count. - Migrated deployment-context documentation to Mango/Source/FruitBank/.github/copilot-instructions.md, preserving the relationship between the server source and plugin after folder removal. --- .github/LLM_PROTOCOL_DECISIONS.md | 2 ++ .github/skills/protocol-audit/references/REPOS.md | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/LLM_PROTOCOL_DECISIONS.md b/.github/LLM_PROTOCOL_DECISIONS.md index 0b83390..bba6d6a 100644 --- a/.github/LLM_PROTOCOL_DECISIONS.md +++ b/.github/LLM_PROTOCOL_DECISIONS.md @@ -158,6 +158,8 @@ The "primary" vs "inherit" distinction is defined in `protocol-audit/references/ | LLMP-DEC-48 | 2026-04-25 | `adr-author` SKILL.md Step 1 restructured: fresh-folder creation rule factored out as shared rule (covers fresh-repo + multi-project cases); template wording "copy of" → "1-paragraph pointer to" (sync with LLMP-DEC-45 #7) | **Drift detected by parallel session**: LLMP-DEC-45 #7 made `/docs/adr/0000-TEMPLATE.md` a 1-line pointer to the canonical `references/ADR_TEMPLATE.md` (eliminating duplication / drift risk). The `adr-author/SKILL.md` Step 1 fresh-repo case still said *"Propose creating `0000-TEMPLATE.md` (copy of `references/ADR_TEMPLATE.md`)"* — stale wording. Additionally, the Step 1 multi-project case did not mention 0000-TEMPLATE creation at all (implicit only via inheritance from the fresh-repo case). **Discovery context**: a parallel Claude Code session, planning a project-scoped ADR folder for `AyCode.Services/docs/adr/`, followed the SKILL Step 1 literally and proposed creating a full template copy — which would have created an inconsistent state across the workspace (one folder with pointer, another with copy). **Fix**: SKILL Step 1 restructured. The fresh-folder creation directive (`README.md` + `0000-TEMPLATE.md`) factored out of the fresh-repo case into a **shared rule applying to any newly-created `docs/adr/` folder** (whether at repo root or project-scoped). The 0000-TEMPLATE wording changed from "copy of" to "1-paragraph pointer to" the canonical, with rationale stated in-line ("single source of truth, avoids template drift"). The README.md description also extended to mention the index table. **Universality preserved (no drót)**: SKILL.md does NOT reference LLMP-DEC IDs (workspace-specific) — it states the principle directly so the skill remains portable to any workspace adopting the protocol-stack. The LLMP-DEC link lives only in this Decision Log entry. | `adr-author/SKILL.md` (Step 1 path resolution section — fresh-folder creation factored out as shared rule + canonical-pointer wording) | | LLMP-DEC-49 | 2026-04-25 | Created `AUTH` topic — registered topic code in `TOPIC_CODES.md`, scaffolded `docs/AUTH/{README, AUTH_ISSUES, AUTH_TODO}.md` at repo root | Bearer-token ADR-0001 (`docs/adr/0001-user-bearer-token-flow.md`, `Accepted (2026-04-25)`) needs a topic home for ongoing issues, planned work, and consumer recipe. **Pre-implementation scaffold**: `README.md` is honest about pre-impl state and includes a Scope table mirroring the ADR's Decision section + a "Security: Never log secrets" guideline (auth-specific phrasing, will trim to cross-ref when `LOG-T-12` lands the canonical version in `LOGGING/README.md`); `AUTH_ISSUES.md` and `AUTH_TODO.md` are empty-state with entry-format templates. **Placement**: repo-root `docs/AUTH/` (not project-level) chosen because AUTH is cross-cutting — affects `AyCode.Services` + `AyCode.Services.Server` + `AyCode.Interfaces` + every consumer. Same parallel-to-projects positioning as `docs/adr/` and `docs/XCUT/` (sibling cross-cutting topics). **`LOG-I-9` / `LOG-I-10`** (auth security leaks closed pre-flight) remain in `LOGGING_ISSUES.md` per their existing Discovery-context note; relocation to `AUTH_ISSUES.md` as `AUTH-I-N` is a separate user-approved follow-up listed in ADR-0001's "Status migration on AUTH topic creation" section — not part of this entry. | `docs-check/references/TOPIC_CODES.md` (new `AUTH` row inserted between `LOG` and `SIG`); 3 new files: `AyCode.Core/docs/AUTH/README.md`, `AUTH_ISSUES.md`, `AUTH_TODO.md` | | LLMP-DEC-50 | 2026-04-26 | New Rule #6 added to all primary `copilot-instructions.md` — Authority, Rule scope, Skill invocation (3 general behavioral principles) | **Diagnosis from real-world session evidence**: a parallel session reviewing FruitBank plugin docs surfaced 5 distinct misinterpretation patterns: (1) inventing topic codes ad-hoc without consulting the canonical registry; (2) proposing TOC-with-offset re-read patterns that work around the no-re-read rule's scope; (3) inventing custom URL schemes (`@Repo:`) outside markdown standard; (4) proposing empty `_ISSUES.md` files without applying the established Status convention; (5) manually reimplementing a skill's workflow instead of invoking the skill. Five distinct surfaces, **one root cause**: the session knew skills/rules existed at the surface but did not follow references to depth, did not treat authoritative registries as binding, and improvised over canonicalized procedures. **Plus self-evidence**: this assistant slipped THREE times using `vN.M` version-label colloquialism in conversation despite LLMP-DEC-47 explicitly forbidding the pattern — proof that Decision Log entries alone do NOT propagate to behavior. Decision Log governance is not session-start mandatory load; rules in `copilot-instructions.md` are. **Fix**: codify three **general** behavioral principles as Rule #6 in all 5 primary `copilot-instructions.md` files. (a) **Authority before proposal** — verify against authoritative source before inventing categories/IDs/conventions. (b) **Rule implications are part of the rule** — apply rules conservatively, don't work around scope with novel patterns. (c) **Skill invocation preferred over reimplementation** — invoke skills explicitly rather than ad-hoc reimplementation. **General, not workspace-specific**: the rule text mentions NO specific registry, skill, convention, or workspace artifact — it states principles applicable to any registry, any skill, any future workspace. **Why Rule #6, not Rule #2 extension**: Rules #1-5 are state/input/output mechanics (LOADED_DOCS prefix, docs-before-code, no-re-read, context-recovery, modification consent); Rule #6 is **behavioral correctness** of how proposals are formed — separate functional category, separate rule. **Coverage**: Authority covers misinterpretations 1, 3, 4; Rule implications covers 2; Skill invocation covers 5 — full 5/5 of observed patterns. **Why this might still not be enough**: even codified rules slip in agent behavior (the v-label evidence). Multi-LLM independent validation remains structurally necessary as the final safety net; rule-text shifts the probability, doesn't reach 100%. | `5× primary copilot-instructions.md` (new Rule #6 inserted after Rule #5, before `## Session Setup`) | +| LLMP-DEC-51 | 2026-04-26 | Removed `Mango/FruitBank/` deployment-host folder — REPOS.md inherit count 3 → 2, total 8 → 7 | The `Mango/FruitBank/` folder was originally created (LLMP-DEC-16, LLMP-DEC-19) as a nopCommerce deployment host for the FruitBank company, intended to host `Nop.Plugin.Misc.AIPlugin`. User confirmed the folder is no longer used — empty except for the legacy `.github/copilot-instructions.md`. **Pre-removal content audit**: the file contained only deployment-host meta (host-role description, `@repo` block declaring `type=host, layer=4`, scope-guidance for what NOT to write here, pointers to plugin and framework docs). NO substantive content about the plugin (later renamed MGFBANKPLUG) or FruitBank-Nop code (later renamed FBANKNOP) — pure host-side metadata, irrelevant once the host doesn't exist. **Removed**: `Mango/FruitBank/.github/copilot-instructions.md`, the `.github/` folder, and the parent `Mango/FruitBank/` folder (now empty). **Updated**: `protocol-audit/references/REPOS.md` — inherit count 3 → 2, total entries 8 → 7. **Historical record preserved**: LLMP-DEC-15 (plugin file fill, separate concern), LLMP-DEC-16 (host file fill), LLMP-DEC-19 (host purpose resolution) remain in the Decision Log per append-only governance — they describe a past state of the workspace. **Phase 0.5 of the ID-format migration (LLMP-DEC-50 design context)**: this cleanup is prerequisite to Phase 1, so the upcoming `REPO_PREFIXES.md` reflects the actual 7-repo workspace topology (no MGFBANKHOST prefix needed). | deleted: `Mango/FruitBank/.github/copilot-instructions.md`, `Mango/FruitBank/.github/`, `Mango/FruitBank/`; updated: `protocol-audit/references/REPOS.md` (Inherit table row 8 removed; own-dep-repos Inherit table Mango.FruitBank row removed) | +| LLMP-DEC-52 | 2026-04-26 | Corrective addition to LLMP-DEC-51: deployment-host context re-attributed to FBANKNOP (FruitBank nopCommerce Server) docs | **LLMP-DEC-51 over-pruned**: the agent's content audit before deletion concluded "no substantive content to migrate from the `Mango/FruitBank/` folder" — but the user identified that the deployment-context information (this FruitBank product targets a nopCommerce instance hosting `Nop.Plugin.Misc.AIPlugin` plugin for the FruitBank company) IS meaningful workspace-topology information, not pure host-side metadata. The deleted folder's role description and hosted-plugin pointer were workspace-relevant — they document a real relationship between FBANKNOP (the server-source product) and MGFBANKPLUG (the plugin source). Without that info, the workspace loses the explicit "this source compiles and deploys here" relationship statement. **Fix**: added a new `## Deployment & Hosting` section to `Mango/Source/FruitBank/.github/copilot-instructions.md` (FBANKNOP's primary instruction file). The section captures: (a) FBANKNOP is the nopCommerce server source for a runtime instance; (b) the runtime hosts MGFBANKPLUG; (c) deployment config / runtime state is external to source repo; (d) historical note that `Mango/FruitBank/` folder was the previous tracking location, now removed per LLMP-DEC-51, with the deployment-context info now living at FBANKNOP (where the source code resides). **Append-only preserved**: LLMP-DEC-51 itself is NOT modified — this corrective entry stands as the augmentation. **Why FBANKNOP, not MGFBANKPLUG**: per user judgment ("inkább a FBANKNOP a valószínűbb"), the deployment-context is more naturally attached to the broader server source (FBANKNOP) than to the plugin source (MGFBANKPLUG); the plugin is one component within the deployment, not the deployment itself. **Process lesson for future cleanups**: pre-deletion content audits must distinguish between (a) pure folder-meta (irrelevant once folder is gone) and (b) workspace-topology references that survive folder removal — the latter need explicit re-attribution, not deletion. | `Mango/Source/FruitBank/.github/copilot-instructions.md` (new `## Deployment & Hosting` section inserted between `## Workspace Dependencies` and `## Shared Agent Skills`) | ## Known follow-ups diff --git a/.github/skills/protocol-audit/references/REPOS.md b/.github/skills/protocol-audit/references/REPOS.md index bbbe96a..736c20a 100644 --- a/.github/skills/protocol-audit/references/REPOS.md +++ b/.github/skills/protocol-audit/references/REPOS.md @@ -30,7 +30,6 @@ These files reference AyCode.Core's protocol via blockquote and do NOT repeat th |---|----------------------------|------------------------------------------------------------------------------------------------|------------------|-------------------------------------------| | 6 | Mango.Nop.Core | `H:\Applications\Mango\Source\NopCommerce.Common\4.70\Libraries\Mango.Nop.Core` | framework (2) | Domain framework for NopCommerce plugins | | 7 | Nop.Plugin.Misc.AIPlugin | `H:\Applications\Mango\Source\NopCommerce.Common\4.70\Plugins\Nop.Plugin.Misc.AIPlugin` | consumer (3) | FruitBank plugin source code | -| 8 | Mango.FruitBank | `H:\Applications\Mango\FruitBank` | host (4) | nopCommerce deployment for FruitBank co. | The instruction file to audit for each is: `\.github\copilot-instructions.md`. @@ -52,7 +51,6 @@ The instruction file to audit for each is: `\.github\copilot-instructi |---------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------| | Mango.Nop.Core | `AyCode.Core: ../../../../../../Aycode/Source/AyCode.Core` | | Nop.Plugin.Misc.AIPlugin | `Mango.Nop.Core: ../../Libraries/Mango.Nop.Core`, `AyCode.Core: ../../../../../../Aycode/Source/AyCode.Core` | -| Mango.FruitBank | `AyCode.Core: ../../Aycode/Source/AyCode.Core` | ## Invariants by type